chore(frontend): dependency update (@cocoar/* → 2.13.0) + Set-Password modal size fix#111
Merged
Merged
Conversation
The Set-Password modal is a non-routed modal — UserList teleports it into a full-screen `.password-modal-overlay` with no overlay host to size the panel. ModalLayout's `.modal-container` is `width:100%; height:100%`, so it filled the entire overlay (i.e. the whole viewport) for a single password input. The `width="28rem"` prop that looked like it sized it is dead (ModalLayout's `width` is `@deprecated` and ignored — size is owned by the opener). Fix: wrap the modal in a `.password-modal-panel` that caps the width (28rem, viewport-clamped) and override the container height to `auto` + an 85vh cap, so it sizes to its content (mirrors the routed MODAL_MD size). Also drop the dead `width` prop from the call site. Verified live: the modal now renders as a compact 448×245 centered box. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bump the frontend dependency set: - @cocoar/vue-* (ui, data-grid, fragment-parser, localization, page-builder, script-editor) 2.7.0 → 2.13.0 (the design system — owner-authored, taken along wholesale). - @cocoar/signalarrr 4.3.1 → 4.3.2. - vue 3.5.35 → 3.5.39, vite 8.0.16 → 8.1.2, vue-tsc 3.3.4 → 3.3.6, tailwindcss + @tailwindcss/vite 4.3.0 → 4.3.2, @playwright/test 1.60.0 → 1.61.1. All same-major (patch/minor). `pnpm type-check` + `pnpm build` green; a chrome-devtools smoke of the heaviest design-system view (the App modal — tab group + two AG grids + settings tabs + form controls) renders cleanly with zero console errors under @CocoAr 2.13.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One combined frontend PR (per owner request).
1. Set-Password modal size fix
The Set-Password modal is a non-routed modal —
UserListteleports it into afull-screen overlay with no host to size the panel, so
ModalLayout'swidth:100%; height:100%container filled the whole viewport for a singlepassword input (the
width="28rem"prop is dead/@deprecated). Wrapped it in a.password-modal-panel(28rem, viewport-clamped) +height:auto/85vh cap so itsizes to content. Verified live: compact 448×245 centered box.
2. Dependency update
script-editor) 2.7.0 → 2.13.0 — the design system (owner-authored, taken
along wholesale).
tailwindcss + @tailwindcss/vite 4.3.0 → 4.3.2, @playwright/test 1.60.0 → 1.61.1.
All same-major (patch/minor); no majors.
Verification
pnpm type-check+pnpm buildgreen (no type errors from the 6-minor @CocoArjump). chrome-devtools smoke of the heaviest design-system view — the App modal
(tab group + two AG grids + settings tabs + form controls) — renders cleanly
with zero console errors under @CocoAr 2.13.0. Frontend-only.
🤖 Generated with Claude Code